Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 1 | wireframe-sprint#1188
Open
mo-omer wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 1 | wireframe-sprint#1188mo-omer wants to merge 2 commits intoCodeYourFuture:mainfrom
mo-omer wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mo-omer
added
the
Needs Review
cjyuan
added
Review in progress
cjyuan
reviewed
Feb 20, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
To better match the wireframe, can you align the height of the images in articles 2 and 3?
-
The bottom border of articles 2 and 3 are covered by the footer. Can you prevent this from happening?
-
According to https://validator.w3.org/, there are errors in your HTML code. Can you fix them?
-
Can you improve the Lighthouse Accessibility score from 96 to 100?
cjyuan
added
Reviewed
mo-omer
added
the
Needs Review
Contributor
|
Changes look good. Well done. |
cjyuan
added
Complete
Contributor
|
Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed all tasks to match the guidelines given in the html and css templates for the wireframe layout
fixed footer to the bottom of the viewport based on previous reviewer feedback
improved code to prevent footer overlap bottom of articles
improved accessibility by assigning same header hierarchy to articles
adjusted image hight and width and fixed code error